Skip to content

C++20 without removing header#5

Merged
tupek2 merged 3 commits into
mainfrom
task/white238/cpp20_without_removing_header
Mar 19, 2026
Merged

C++20 without removing header#5
tupek2 merged 3 commits into
mainfrom
task/white238/cpp20_without_removing_header

Conversation

@white238

Copy link
Copy Markdown
Member

Alternative to #4

  • Fixed the C++20 incomplete-type failure by removing std::vector from DataStore (it only had a forward-decl there) and storing upstream step indices instead; UpstreamStates is now constructed at the call site when evaluating forward/VJP (src/gretl/data_store.hpp:243, src/gretl/state_base.cpp:12, src/gretl/data_store.cpp:29).
  • Fixed C++20 -Wdeprecated-this-capture (warnings-as-errors) by changing the placeholder lambdas in DataStore::add_state() to capture step explicitly instead of [=] (src/gretl/data_store.cpp:176).

@white238 white238 requested a review from tupek2 March 17, 2026 16:49

@tupek2 tupek2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. I think this makes an asan issue I used to have less likely to pop back up too.

Comment thread src/gretl/data_store.hpp Outdated
Co-authored-by: Michael Tupek <135926736+tupek2@users.noreply.github.com>
@tupek2 tupek2 merged commit d9d7d91 into main Mar 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants